Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement heatmap multiples #125

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat: implement heatmap multiples #125

wants to merge 3 commits into from

Conversation

dv-usama-ansari
Copy link
Contributor

Closes #112

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified @dvdanielamoitzi
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • Fixed behavior of heatmaps when multiple categorical columns are selected

Screenshots

image

Additional notes for the reviewer(s)

  • The performance of the component is noticeably slow when multiple categorical columns are selected for a medium-large dataset
  • There are errors in the console which refer to incorrect attributes being set to <svg> elements during render
  • The sorting of one of the axes of a heatmap also sort the other heatmaps in sync
  • The labels do not have a good placement if multiple heatmaps are rendered

@dv-usama-ansari dv-usama-ansari self-assigned this Nov 20, 2023
@dv-usama-ansari dv-usama-ansari linked an issue Nov 20, 2023 that may be closed by this pull request
VIS: Restrict Heatmap to 2 categorical columns #112
Open
@dv-usama-ansari dv-usama-ansari added release: minor PR merge results in a new minor version type: feature New feature or request labels Nov 20, 2023
@dvmartinweigl
Copy link
Contributor

Unfortunately this does not scale well in Bioinsight. Also there are not scrollbars if the matrix overflows.

image

@dvmartinweigl
Copy link
Contributor

@dv-usama-ansari and me decided to limit the number of categorical columns to 2, as there is some misbehavior and bugs in the matrix approach. Also this does not scale well in our dashboard like applications.

We can keep this PR open and take another look at a later point.

@dv-usama-ansari
Copy link
Contributor Author

@dv-usama-ansari and me decided to limit the number of categorical columns to 2, as there is some misbehavior and bugs in the matrix approach. Also this does not scale well in our dashboard like applications.

We can keep this PR open and take another look at a later point.

Please note that I have entered comments in the code to indicate this, we therefore do not need a separate PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdanielamoitzi dvdanielamoitzi Awaiting requested review from dvdanielamoitzi

@dvmartinweigl dvmartinweigl Awaiting requested review from dvmartinweigl

At least 1 approving review is required to merge this pull request.

Assignees

@dv-usama-ansari dv-usama-ansari

Labels
release: minor PR merge results in a new minor version type: feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VIS: Restrict Heatmap to 2 categorical columns
2 participants
@dv-usama-ansari @dvmartinweigl