Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate demos to svelte and storybook #261

Closed
wants to merge 37 commits into from
Closed

Migrate demos to svelte and storybook #261

wants to merge 37 commits into from

Conversation

dvsilviyageo
Copy link
Contributor

@dvsilviyageo dvsilviyageo commented Feb 3, 2023 •
edited
Loading

Summary:

  • Added storybook.
  • Added plotly, echarts and vega-lite demos to storybook.

Screencast:

Peek.2023-02-16.10-38.mp4

@dvsilviyageo dvsilviyageo changed the title Dmoitzi/260 add storybook Add storybook Feb 6, 2023
@dvsilviyageo dvsilviyageo changed the title Add storybook Migrate demos to svelte and storybook Feb 16, 2023
@dvsilviyageo dvsilviyageo requested review from dvdanielamoitzi and removed request for dvdanielamoitzi February 16, 2023 09:39
@dvsilviyageo dvsilviyageo added the enhancement New feature or request label Feb 16, 2023
@dvsilviyageo dvsilviyageo linked an issue Feb 16, 2023 that may be closed by this pull request
Migrate demos to svelte & storybook #267
Open
@dvsilviyageo dvsilviyageo marked this pull request as ready for review February 16, 2023 09:50
@dvsilviyageo
Copy link
Contributor Author

dvsilviyageo commented Feb 21, 2023 •
edited
Loading

  • In treemap echarts, setting the color creates an issue.
  • Setting the type for onboardingUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvdanielamoitzi dvdanielamoitzi Awaiting requested review from dvdanielamoitzi

Assignees

@dvdanielamoitzi dvdanielamoitzi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate demos to svelte & storybook
2 participants
@dvsilviyageo @dvdanielamoitzi