refactor(client)!: drop the legacy validation_error field from RG configs

- the server now exposes only the structured validation_errors list on RG configs (MR 3499 standard)
- discovery configs and DC libraries keep the singular field; their API is unchanged

Author: carlosfunk

datamasque/client/models/rg_config.py

@@ -44,7 +44,6 @@ class RGConfig(BaseModel):
     # Server-populated read-only fields, excluded from request bodies.
     id: Optional[RGConfigId] = Field(default=None, exclude=True)
     is_valid: Optional[ValidationStatus] = Field(default=None, exclude=True)
-    validation_error: Optional[str] = Field(default=None, exclude=True)
     validation_errors: list[ValidationErrorDetails] = Field(default_factory=list, exclude=True)
     created: Optional[datetime] = Field(default=None, exclude=True)
     modified: Optional[datetime] = Field(default=None, exclude=True)

datamasque/client/rg_configs.py

@@ -73,15 +73,14 @@ def create_rg_config(self, config: RGConfig) -> RGConfig:
         Creates a new RG config on the server.
 
         Sets the config's server-assigned fields
-        (`id`, `is_valid`, `validation_error`, `validation_errors`, `created`, `modified`) and returns the config.
+        (`id`, `is_valid`, `validation_errors`, `created`, `modified`) and returns the config.
         """
 
         data = config.model_dump(exclude_none=True, by_alias=True, mode="json")
         response = self.make_request("POST", "/api/ruleset-generation-configs/", data=data)
         created = RGConfig.model_validate(response.json())
         config.id = created.id
         config.is_valid = created.is_valid
-        config.validation_error = created.validation_error
         config.validation_errors = created.validation_errors
         config.created = created.created
         config.modified = created.modified
@@ -110,7 +109,6 @@ def update_rg_config(self, config: RGConfig) -> RGConfig:
         response = self.make_request("PUT", f"/api/ruleset-generation-configs/{config.id}/", data=data)
         updated = RGConfig.model_validate(response.json())
         config.is_valid = updated.is_valid
-        config.validation_error = updated.validation_error
         config.validation_errors = updated.validation_errors
         config.modified = updated.modified
         logger.debug('Update of RG config "%s" successful', config.name)

tests/test_rg_configs.py

@@ -266,7 +266,6 @@ def test_create_and_update_rg_config_populate_validation_errors(client: DataMasq
         "name": "test_config",
         "config_yaml": CONFIG_YAML,
         "is_valid": "invalid",
-        "validation_error": "Missing required field: labels",
         "validation_errors": [
             {
                 "message": "Missing required field: labels",
@@ -279,7 +278,7 @@ def test_create_and_update_rg_config_populate_validation_errors(client: DataMasq
         "created": "2025-06-01T10:00:00Z",
         "modified": "2025-06-01T10:00:00Z",
     }
-    valid_response = {**invalid_response, "is_valid": "valid", "validation_error": None, "validation_errors": []}
+    valid_response = {**invalid_response, "is_valid": "valid", "validation_errors": []}
 
     with requests_mock.Mocker() as m:
         m.post("http://test-server/api/ruleset-generation-configs/", json=invalid_response, status_code=201)
@@ -305,7 +304,6 @@ def test_create_and_update_rg_config_populate_validation_errors(client: DataMasq
 
     for request in m.request_history:
         assert "validation_errors" not in request.json()
-        assert "validation_error" not in request.json()
 
 
 def test_update_rg_config(client: DataMasqueClient, rg_config: RGConfig) -> None:
@@ -476,21 +474,21 @@ def test_get_default_rg_config_yaml(client: DataMasqueClient) -> None:
 
 
 def test_rg_config_parses_validation_fields() -> None:
-    """`is_valid` and `validation_error` round-trip from API responses."""
+    """`is_valid` and `validation_errors` round-trip from API responses."""
     config = RGConfig.model_validate(
         {
             "id": CONFIG_ID_1,
             "name": "my_config",
             "config_yaml": "labels: []",
             "is_valid": "invalid",
-            "validation_error": "bad shape on line 3",
+            "validation_errors": [{"message": "bad shape on line 3", "line_number": 3, "column_number": 1}],
             "created": "2025-01-01T12:00:00Z",
             "modified": "2025-01-02T12:00:00Z",
         }
     )
 
     assert config.is_valid is ValidationStatus.invalid
-    assert config.validation_error == "bad shape on line 3"
+    assert config.validation_errors[0].message == "bad shape on line 3"
 
 
 def test_rg_config_validation_fields_optional() -> None:
@@ -505,7 +503,7 @@ def test_rg_config_validation_fields_optional() -> None:
     )
 
     assert config.is_valid is None
-    assert config.validation_error is None
+    assert config.validation_errors == []
 
 
 def test_unwrap_rg_config_id_passes_through_strings() -> None: