Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests for XNAT Central and NITRC-IR #123

Open
bpoldrack opened this issue Sep 30, 2021 · 0 comments
Open

Refactor tests for XNAT Central and NITRC-IR #123

bpoldrack opened this issue Sep 30, 2021 · 0 comments

Comments

@bpoldrack
Copy link
Member

bpoldrack commented Sep 30, 2021

As mentioned in PR #121, refactor the tests in tests/test_xnatcentral.py and tests/test_nitrcir.py in order to have generic tests, that would loop over definitions of a targeted XNAT instance and project/subject/etc. to test against. This could involve authenticated targets later on as well (whenever we find a way to test that from within CI).

The tests in both files are already as good as identical and rely just on differently specifiec constants at the top of their respective file. Should like become a dict or some other structure rather than a collection of constants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant