Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaladExampleDatasetExtractor.extract(_=None) #388

Open
mih opened this issue Jul 19, 2023 · 0 comments
Open

MetaladExampleDatasetExtractor.extract(_=None) #388

mih opened this issue Jul 19, 2023 · 0 comments

Comments

@mih
Copy link
Member

mih commented Jul 19, 2023

The example extractor implementation declares a signature that contains _=None. I find this confusing. It corresponds to the output_location: Optional[Union[IO, str] argument of the base class.

To make this connection is important for understanding the description in http://docs.datalad.org/projects/metalad/en/latest/user_guide/writing-extractors.html#extract

I believe this makes things needlessly complex. Why not simply spell things out and add a comment that it is used, because of DataOutputCategory.IMMEDIATE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant