Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract config reader functionality for train schema #25

Open
CBroz1 opened this issue May 17, 2022 · 1 comment
Open

Abstract config reader functionality for train schema #25

CBroz1 opened this issue May 17, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@CBroz1
Copy link
Contributor

CBroz1 commented May 17, 2022

The following was provided as feedback

A lot of functionality could be abstracted as it is not DJ specific. For example config parsing is currently done within a schema (example) while an own class could be the better choice here. This could also robustify the code, help with versioning, etc. For example, say a lab uses a non-standard DLC file, how would I be able to use elements w/o actually changing the code? If config parsing is in its only module, features like this could be very easy implemented.

@CBroz1 CBroz1 added the enhancement New feature or request label May 17, 2022
@CBroz1 CBroz1 self-assigned this May 17, 2022
@CBroz1 CBroz1 added this to the 2022Q4 milestone May 20, 2022
@CBroz1
Copy link
Contributor Author

CBroz1 commented Sep 22, 2022

This would likely not involve any new features, but rater a refactoring of existing code and demonstrating coverage via existing pytests

@CBroz1 CBroz1 removed their assignment Sep 22, 2022
@CBroz1 CBroz1 self-assigned this Jan 20, 2023
@kabilar kabilar removed this from the 2022Q4 milestone Feb 18, 2023
@CBroz1 CBroz1 removed their assignment Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants