Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrity protections matching loaded data with paramset #88

Open
CBroz1 opened this issue Sep 21, 2022 · 1 comment
Open

Integrity protections matching loaded data with paramset #88

CBroz1 opened this issue Sep 21, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@CBroz1
Copy link
Contributor

CBroz1 commented Sep 21, 2022

Current

A user could

imaging.ProcessingParamSet.insert_new_params(
    processing_method='suite2p', 
    paramset_idx=1, 
    params=my_params_dict,
    paramset_desc='my description'
)
imaging.ProcessingTask.insert1(dict(
    **scan_key,
    paramset_idx=1, 
    processing_output_dir='/my/dir'
))
  • If my_dir exists, we load the results regardless of whether or not the output in this directory matches paramset_idx=1.
  • If the paramset were wrong, this would result in a mismatch of params and analyses which is not aligned with general DataJoint integrity protection principles.
  • If my_dir was a previous analysis, but the user might mistakenly load instead of trigger a new analysis.

Future

  1. Minor fix: when loading, check that every item specified in the paramset is true of the relevant directory.
  2. Major fix: position 'load vs. trigger' upstream of ProcessingParamset and always trigger insert_new_params when loading existing results.
@CBroz1 CBroz1 added the enhancement New feature or request label Sep 21, 2022
@CBroz1
Copy link
Contributor Author

CBroz1 commented Sep 22, 2022

@kabilar - I'm reviewing outstanding issues to label a subset as 'good-first-issue'. If you can propose a path forward on this, it may qualify for that label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant