Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator fails with node group XX has volume claim template without storage class which is not allowed #198

Open
cintoSunny opened this issue Jan 9, 2025 · 0 comments

Comments

@cintoSunny
Copy link
Contributor

The operator fails with node group historical has volume claim template without storage class which is not allowed
This is because there is no storageClassName in the Volume Claim Templates. This is the exact check

func validateNodeVolumeClaimTemplateSpec(nodeSpec *v1alpha1.DruidNodeSpec) error {

func validateNodeVolumeClaimTemplateSpec(nodeSpec *v1alpha1.DruidNodeSpec) error {
	for _, vct := range nodeSpec.VolumeClaimTemplates {
		if vct.Spec.StorageClassName == nil || *vct.Spec.StorageClassName == "" {
			return fmt.Errorf("node group %s has volume claim template without storage class which is not allowed: %s",
				nodeSpec.NodeType, vct.Name)
		}
	}
	return nil
}

This was recently added, and hence existing runs are failing that doesn't have this field - StorageClassName. Is there any particular reason we added this? I mean, apart from volumeExpansion do we need it anywhere? I can change the code accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant