-
Notifications
You must be signed in to change notification settings - Fork 3.3k
improve(uploadFiles): move upload files related props to its own oject #15179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ Meticulous spotted 0 visual differences across 1014 screens tested: view results. Meticulous evaluated ~8 hours of user flows against your PR. Expected differences? Click here. Last updated for commit d34b603. This comment will update as new commits are pushed. |
Bundle ReportChanges will increase total bundle size by 114 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: datahub-react-web-esmAssets Changed:
Files in
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ce843f0 to
1fdcde3
Compare
1fdcde3 to
d34b603
Compare
chriscollins3456
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice refactor
Follow up from #15080
depends on #15166