Skip to content

Conversation

@v-tarasevich-blitz-brain
Copy link
Contributor

@v-tarasevich-blitz-brain v-tarasevich-blitz-brain commented Nov 3, 2025

Follow up from #15080

depends on #15166

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment labels Nov 3, 2025
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Nov 3, 2025

✅ Meticulous spotted 0 visual differences across 1014 screens tested: view results.

Meticulous evaluated ~8 hours of user flows against your PR.

Expected differences? Click here. Last updated for commit d34b603. This comment will update as new commits are pushed.

@codecov
Copy link

codecov bot commented Nov 3, 2025

Bundle Report

Changes will increase total bundle size by 114 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
datahub-react-web-esm 28.61MB 114 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: datahub-react-web-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/index-*.js 114 bytes 18.99MB 0.0%

Files in assets/index-*.js:

  • ./src/alchemy-components/components/Editor/extensions/fileDragDrop/FileDragDropExtension.tsx → Total Size: 10.32kB

  • ./src/alchemy-components/components/Editor/toolbar/FileUploadButton.tsx → Total Size: 1.2kB

  • ./src/app/entityV2/summary/documentation/EditDescriptionModal.tsx → Total Size: 1.95kB

  • ./src/alchemy-components/components/Editor/toolbar/Toolbar.tsx → Total Size: 4.3kB

  • ./src/alchemy-components/components/Editor/toolbar/FileUploadContent.tsx → Total Size: 3.36kB

  • ./src/alchemy-components/components/Editor/types.ts → Total Size: 376 bytes

  • ./src/app/entityV2/shared/tabs/Dataset/Schema/components/SchemaFieldDrawer/AboutFieldTab.tsx → Total Size: 3.23kB

  • ./src/alchemy-components/components/Editor/Editor.tsx → Total Size: 3.19kB

  • ./src/app/entityV2/shared/tabs/Documentation/components/DescriptionEditor.tsx → Total Size: 6.87kB

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice refactor

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Nov 4, 2025
@chriscollins3456 chriscollins3456 merged commit bf21758 into master Nov 4, 2025
33 checks passed
@chriscollins3456 chriscollins3456 deleted the vt--ch-877--refactor-upload-props branch November 4, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops PR or Issue related to DataHub backend & deployment pending-submitter-merge product PR or Issue related to the DataHub UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants