Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] There is max_retries option for Tableau ingestion but it won't work #10760

Closed
YuriyGavrilov opened this issue Jun 21, 2024 · 2 comments
Closed
Labels
bug Bug report

Comments

@YuriyGavrilov
Copy link
Contributor

YuriyGavrilov commented Jun 21, 2024

Describe the bug
In the docs:

max_retries
integer
Number of retries for failed requests.
Default: 3

In fact:

configured successfully. DataHubRestEmitter: configured '
           'to talk to http://datahub-gms-datahub-gms:8080 with token: eyJh**********_1YA\n'
           'Failed to configure the source (tableau): 1 validation error for TableauConfig\n'
           'max_retries\n'
           '  extra fields not permitted (type=value_error.extra)\n',
           "2024-06-21 08:59:32.429377 [exec_id=9debef30-5ba0-4a53-911c-a111147fe483] INFO: Failed to execute 'datahub ingest'",

Tried this way:

source:
    type: tableau
    config:
        ingest_owner: false
        platform_instance: tableau_prod
        connect_uri: 'https://tableau.XX.XX'
        ingest_tables_external: false
        ingest_tags: false
        page_size: 2
        max_retries: 7
        workbook_page_size: 1
        stateful_ingestion:
            enabled: true
            remove_stale_metadata: true

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

options to configure retries

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. ]

Additional context

Datahub version 0.12

@YuriyGavrilov YuriyGavrilov added the bug Bug report label Jun 21, 2024
@mayurinehate
Copy link
Collaborator

max_retries was introduced in 0.12.1.1 and is available all versions thereafter. Please update datahub CLI version to use this config.

You can refer to versioned docs on datahub to confirm config options available in particular DataHub version.
image

@YuriyGavrilov
Copy link
Contributor Author

Thx 🙏 @mayurinehate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report
Projects
None yet
Development

No branches or pull requests

2 participants