Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vscode ref issue #1768 #1769

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Conversation

moker-spaghetti
Copy link
Contributor

fix #1768

@Ekrekr Ekrekr requested a review from GJMcGowan June 28, 2024 14:55
vscode/server.ts Outdated
&& action?.target?.name !== undefined && action.target.name === linkedTable.name
));
if (foundCompileAction.length === 0) {
// raise Error
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary comments IMO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are removed on the next commit. Thanks for the review!

@Ekrekr Ekrekr merged commit b322655 into dataform-co:main Jul 8, 2024
1 of 2 checks passed
@moker-spaghetti moker-spaghetti deleted the fix-vscode-ref branch July 8, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants