-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override database config is not applied to Auto generated assertions #1295
Comments
A more elegant solution that we have planned for this is CLI flags for |
I'm looking forward to it! |
Config option was not the fix, #1602 demonstrates however confirms that this was not an issue with Core's Will create a new PR to add these to the tests, and fix the underlying cause. |
I'm a bit stumped by this, but I've narrowed down the issue and it is clear it only happens in the CLI. Adding more tests for Dataform Core (#1603) demonstrates that:
Adding more tests for Dataform CLI (#1604) demonstrates that:
|
Also running into this. We set the database in the config block of each .sqlx and assertions in the config block don't work |
About this https://docs.dataform.co/guides/assertions#auto-generated-assertions .
I am using
dataform run --vars
option to embed a new database(GCP project_id) into each sqlx files tooverride the default_database in my CI/CD.
Not from code base but from behavior base, I found that override is not applied to auto generated assertions.
Is it an expected behavior or just a bug?
For example:
dataform.json
some_query.sqlx
If you run
dataform run --actions=some_query --vars=embed_my_prd_database=my-prd-project
expect: success
but I got followings because I was using SA credential of
my-prd-project
not ofmy-dev-project
The text was updated successfully, but these errors were encountered: