Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Citation page full of warnings #855

Open
maneesha opened this issue Jun 2, 2023 · 3 comments
Open

Citation page full of warnings #855

maneesha opened this issue Jun 2, 2023 · 3 comments
Labels
type:template and tools Issue about template and tools

Comments

@maneesha
Copy link
Contributor

maneesha commented Jun 2, 2023

The CITATION page linked to from this contributors section is full of warnings/errors.

image

@zkamvar
Copy link
Contributor

zkamvar commented Jun 23, 2023

This is due to the fact that this lesson was built in a way that deviated from our other lessons, so the transition did not catch this issue.

I believe the initial iteration was created from #184, which was opened by @fmichonneau. I believe the update copyright python script can be scrapped as the copyright will be updated on the bottom of the page.

WRT to the AUTHORS, That ties in with the issue of how we standardize authorship recognition across our lessons. The reason it disappears right now is because {sandpaper} looks for all markdown files and R scripts for a lesson and copies them to the site/built folder (the md-outputs branch on CI) before generating the content (so that we do not pollute the workspace with generated content). Because AUTHORS does not have an extension, it is ignored.

@zkamvar
Copy link
Contributor

zkamvar commented Jun 23, 2023

One solution to fix the warnings is to change AUTHORS to AUTHORS.md (the file name and in the CITATION.Rmd file).

Another solution is to explicitly include the AUTHORS file on the {sandpaper} end as a special known file, but I'm a bit reluctant to do that at the moment because we do not yet know the shape of how author credit will happen.

@tobyhodges tobyhodges added the type:template and tools Issue about template and tools label Jul 10, 2024
@ragamouf
Copy link
Contributor

ragamouf commented Aug 9, 2024

Hello! Popping up because I wanted to cite and promote this lesson. Now it appears that the cite button is simply broken. Was this an accidental result of the latest updates? Please let me know how I can help!
Screenshot 2024-08-09 at 4 54 07 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:template and tools Issue about template and tools
Projects
None yet
Development

No branches or pull requests

4 participants