Skip to content

Conversation

@goodwillpunning
Copy link
Contributor

What does this PR do?

This PR adds a create-profiler-dashboard CLI command. Once executed, the command will deploy a profiler summary as a Databricks dashboard to the user's workspace.

Relevant implementation details

The create-profiler-dashboard CLI command performs 3 actions:

  1. Uploads the profiler extract to a UC volume
  2. Deploys a workflow for ingesting the extract file and converting to Delta tables
  3. Deploys a summary dashboard based on the source technology that was profiled

Caveats/things to watch out for when reviewing:

The job can be uninstalled when a Lakebridge uninstall command is executed.

Linked issues

Compliments #1623

Functionality

  • added relevant user documentation
  • added new CLI command
  • modified existing command: databricks labs lakebridge ...
  • ... +add your own

Tests

  • manually tested
  • added unit tests
  • added integration tests

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.15%. Comparing base (6c56eb3) to head (d488966).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/databricks/labs/lakebridge/cli.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2134      +/-   ##
==========================================
- Coverage   64.17%   64.15%   -0.03%     
==========================================
  Files          99       99              
  Lines        8364     8370       +6     
  Branches      853      853              
==========================================
+ Hits         5368     5370       +2     
- Misses       2813     2817       +4     
  Partials      183      183              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

✅ 51/51 passed, 11 flaky, 2m54s total

Flaky tests:

  • 🤪 test_validate_mixed_checks (170ms)
  • 🤪 test_validate_invalid_schema_path (0s)
  • 🤪 test_validate_successful_schema_check (165ms)
  • 🤪 test_validate_invalid_schema_check (1ms)
  • 🤪 test_validate_non_empty_tables (8ms)
  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[False] (12.612s)
  • 🤪 test_transpiles_informatica_to_sparksql (14.173s)
  • 🤪 test_transpile_teradata_sql_non_interactive[True] (14.711s)
  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[True] (3.975s)
  • 🤪 test_transpile_teradata_sql_non_interactive[False] (5.636s)
  • 🤪 test_transpile_teradata_sql (8.886s)

Running from acceptance #2904

Copy link
Collaborator

@sundarshankar89 sundarshankar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@gueniai gueniai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gueniai gueniai added this pull request to the merge queue Nov 7, 2025
Merged via the queue into main with commit 09bd34e Nov 7, 2025
9 of 10 checks passed
@gueniai gueniai deleted the feature/create_profiler_dashboards_cmd branch November 7, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat/profiler Issues related to profilers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants