Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model validation with feature store should be supported. #70

Closed
mingyu89 opened this issue Mar 20, 2023 · 7 comments
Closed

Model validation with feature store should be supported. #70

mingyu89 opened this issue Mar 20, 2023 · 7 comments

Comments

@mingyu89
Copy link
Contributor

Mode validation uses mlflow.evaluate. Currently it doesn't support evaluating models registered with databricks feature store.

pleelapr added a commit to pleelapr/mlops-poc that referenced this issue May 22, 2023
…validation

Previously, attempting to validate feature store models would throw an error as detailed in issue databricks/mlops-stacks#70. This change disables that functionality by commenting out relevant code.
@aminebizid
Copy link

Any news about this limitation please?

@jackroseman
Copy link

I am also wondering when this feature is coming. Thanks!

@skaliy
Copy link

skaliy commented Dec 18, 2023

Any updates? :)

@arpitjasa-db
Copy link
Collaborator

Hi we're looking into adding support for this, the tricky part is we need to update underlying feature store and MLflow components to get this to work, but will hopefully have an update for you all soon!

@david-straub
Copy link

Any updates?

@arpitjasa-db
Copy link
Collaborator

@david-straub we are currently reviewing a PR to add this functionality, but note this workaround will be slightly limited in that we cannot enable baseline comparison, as we need to provide a model_uri of a pyfunc model (so this means it's not possible to compare a new FS model with a baseline FS model)

@arpitjasa-db
Copy link
Collaborator

We just merged #165 thanks to @aliazzzdat! This workaround should resolve most use cases for this issue, but if there's any other problems, please open another issue thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants