Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] ImageController #265

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Jeremboo
Copy link

@Jeremboo Jeremboo commented Apr 8, 2020

I recently needed to hack the lib to add a feature to test different images quickly.

I thought about something like that:

var images = { path1: 'myImage.png'};
gui.addImage(images, 'path1').onChange((image) => {
  console.log('do something with the image loaded');
});

Because I'll need it multiple time (and some people were interested too) I did a short library where you can see the usage: dat.gui.image.

I tested the code and the augmented functions (.name(), .listen(), .remove()).

Feel free to recommend me some updates in term of code or UX!

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Jeremboo
Copy link
Author

Jeremboo commented Apr 8, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

&& add boolean in onechange
@gsimone gsimone mentioned this pull request Nov 27, 2020
@andrevenancio
Copy link

When can we expect this to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants