Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2665 cities from data.gov #2680

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

ziv17
Copy link
Collaborator

@ziv17 ziv17 commented Jul 25, 2024

load cities from data.gov instead of csv file
Closes #2665

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 7.40741% with 100 lines in your changes missing coverage. Please review.

Project coverage is 52.61%. Comparing base (400af13) to head (69a33f1).
Report is 72 commits behind head on dev.

Files Patch % Lines
anyway/parsers/cities.py 0.00% 56 Missing ⚠️
anyway/models.py 29.62% 19 Missing ⚠️
main.py 0.00% 13 Missing ⚠️
anyway/parsers/streets.py 0.00% 11 Missing ⚠️
anyway/parsers/cbs/executor.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2680      +/-   ##
==========================================
- Coverage   53.22%   52.61%   -0.61%     
==========================================
  Files         119      122       +3     
  Lines        9924    10154     +230     
==========================================
+ Hits         5282     5343      +61     
- Misses       4642     4811     +169     
Flag Coverage Δ
unittests 52.61% <7.40%> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ziv17 ziv17 force-pushed the 2665-cities-from-data.gov branch from 5d45fcb to 9a520a9 Compare July 25, 2024 15:11
@ziv17 ziv17 marked this pull request as ready for review August 2, 2024 10:17
@ziv17 ziv17 requested a review from atalyaalon August 2, 2024 10:17
@ziv17 ziv17 force-pushed the 2665-cities-from-data.gov branch from a1827e8 to 69a33f1 Compare August 2, 2024 11:06
@atalyaalon atalyaalon merged commit 6eaa05e into data-for-change:dev Aug 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update cities table regularly from data.gov
3 participants