Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace zoom slider #88

Closed
dasmoth opened this issue Aug 3, 2014 · 7 comments
Closed

Replace zoom slider #88

dasmoth opened this issue Aug 3, 2014 · 7 comments
Milestone

Comments

@dasmoth
Copy link
Owner

dasmoth commented Aug 3, 2014

The current we use as a zoom slider has at least two major problems:

  1. It doesn't give any feedback about the toggle-zoom (space-bar) functionality, making that functionality hard to discover and meaning you have no indication of what hitting space will do at any given moment.
  2. It looks super-ugly in Internet explorer, and there seems to be no way to style it even remotely like what we get on other platforms short of re-implementing it.

Therefore, I suggest implementing a new slider that looks reasonably close to a standard but has feedback for toggle-zooming (maybe a greyed-out second thumb?).

The polyfill code we used to use to get sliders on Mozilla may be useful here.

@dasmoth dasmoth added this to the 0.13 milestone Sep 21, 2014
@dasmoth
Copy link
Owner Author

dasmoth commented Oct 4, 2014

Done

@dasmoth dasmoth closed this as completed Oct 4, 2014
@andreasprlic
Copy link

this looks great!

@Traksewt
Copy link

Traksewt commented Oct 8, 2014

I like the idea. Though I'm not sure if I'm missing some stylesheets, as after I've updated the code, the new 'slider-label' text is listed going down the page instead of horizontally (I assume). The dalliance code is automatically using the public stylesheets (http://www.biodalliance.org/release-0.13/css/dalliance-scoped.css). Are these stylesheets out of sync with the current dev version ?

image

@dlrice
Copy link
Contributor

dlrice commented Oct 8, 2014

In adding the single base highlighter ruler in #111 I have added some classes which are not in the public stylesheets which would at least explain why the location text is all the way to the left and not in the centre.

@dasmoth
Copy link
Owner Author

dasmoth commented Oct 8, 2014

@Traksewt is right, there was a stale stylesheet in the release-0.13 directory. I try to keep the "next release" resources directory reasonably up to date, but it does sometimes slip for a week or two -- if you're using a development version of Biodalliance seriously, it's probably worth keeping your own copy of the resources (css, fonts, help) and setting the prefix option accordingly.

@Traksewt
Copy link

Traksewt commented Oct 8, 2014

great thanks guys, I didn't realise the prefix option for stylesheets. The public css is looking good now, and the slider is looking great.

@dasmoth
Copy link
Owner Author

dasmoth commented Oct 9, 2014

Sounds like there's a need for better documentation regarding how assets get located, have opened biodalliance/dalliance-web#5 to track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants