-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new image for Dask hub #144
Comments
Sounds good! I have a slight preference for creating a new image, but you probably have a better sense of what makes sense here |
More may be needed than simply adding those packages. I tried to roll my own images and it didn't work - I get 404s. If I use the latest Below is an example config that I installed on a local minikube, including those packages. (If you try to repro, don't use the latest k8s v1.22, which is starting to become the default download -- daskhub chart is not compatible). I also include below the logs from the hub and the user pod. To note:
Adding @consideRatio , as this feels a bit like a jhub configuration update is needed, as well. I'd be interested to know what that might be, as I'm not sure how to get more information about what is going wrong.
Hub Logs
User Pod Logs
|
Is jupyterhub-singleuser a conda package? I think jupyterhub-base is one. Are you sure you startup with the latest jupyterhub-singleuser script? The extra package thing must install the extra packages before running the jupyterhub-singleuser script that bundles as an entrypoint part of the python package jupyterhub, and jupyterhub-base contain that without dependecies like node only relevant if you run jh locally etc. I think w. K8s 1.22, you need a new release of dask-gateway helm chart for several reasons, ive fixed them in current main branch but its not released yet. There are also other things to fix, such disabling hub.networkPolicy.enabled=false, also fixed in latest main. All help working towards a release of dask/dask-gateway appreciated. |
When I raised this issue I had successfully created a custom image (based on RAPIDS) which just added
This came up again at the Dask maintainers meeting this week. We are blocked with @jcrist being the only person who can do this. It looks like Jim should have some time for this soon though. |
OK, so it sounds like there is still some work to do here. Deferring discussion of dask-gateway (for the moment -- let's come back to that), what needs to be done just to get jupyter working? The base-notebook Dockerfile has:
On the raw jupyter front, the dask entrypoint runs a dask-docker/notebook/prepare.sh Line 36 in 490c810
It seems tricky to do all 3:
Would switching |
Can we not change the entrypoint to |
I think you are looking at the wrong prepare script. The one I referenced is in the notebook subdirectory. It's a bit convoluted -- maybe we should cleanup the prepare/entrypoint/cmd here. |
I just verified that switching to |
It seems singleuser.defaultUrl isn't working to set the default to lab. Maybe it's related to |
In order for a Docker image to be used with the Daskhub helm chart it needs
dask-gateway
andjupyterhub-singleuser
to be installed.Neither of our official images have those packages so I propose we either add them to the notebook image or create a new image specifically for Daskhub.
The text was updated successfully, but these errors were encountered: