Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2024.10.0 #401

Closed
4 tasks
fjetter opened this issue Oct 16, 2024 · 7 comments
Closed
4 tasks

Release 2024.10.0 #401

fjetter opened this issue Oct 16, 2024 · 7 comments
Labels

Comments

@fjetter
Copy link
Member

fjetter commented Oct 16, 2024

Release version 2024.10.0
Planned release date 2024-10-16
Status Off schedule
Release manager @fjetter

Best effort

Try to close before the release but will not block the release

  • ...
  • ...

Blocker

Issues that would cause us to block and postpone the release if not fixed

  • ...
  • ...

Comments

We're a little off schedule here. We didn't release last friday but would like to cut another release before we merge a possibly impactful PR in distributed. Therefore, I'm planning to cut a release tomorrow if there are no objections

@fjetter
Copy link
Member Author

fjetter commented Oct 17, 2024

done

@fjetter fjetter closed this as completed Oct 17, 2024
@pentschev
Copy link
Member

I just noticed the new release is still not in conda-forge, even though the @fjetter merged the release conda-forge/dask-core-feedstock#219 . I then went to investigate a bit and found that Distributed didn't get a similar PR, which was previously done manually by @jrbourbeau (see conda-forge/distributed-feedstock#293 for example) instead of automatically by the conda-forge bot. I don't know if that's intentional or not that this feature is disabled in the https://github.com/conda-forge/distributed-feedstock , so it's one thing to keep in mind for future releases. In the meantime I opened conda-forge/distributed-feedstock#294 to take care of the 2024.10.0 release, but I need someone to approve/merge, since I'm not authorized to do it there. @fjetter @charlesbluca would one of you mind having a look?

@charlesbluca
Copy link
Member

Thanks @pentschev! Left some comments, happy to approve/merge when things are passing. Should also note that once these packages are in and published we should open a similar PR in dask-feedstock to cut a new release of the dask metapackage

I don't know if that's intentional or not that this feature is disabled

Haven't followed the feedstocks closely, but if I could guess I'd imagine this might've been turned off in distributed and dask's feedstocks since they're dependent on dask-core and distributed, respectively, and the auto-generated PRs would fail at time of opening since they need to be merged and built in sequential order (dask-core, distributed, dask)

@pentschev
Copy link
Member

Should also note that once these packages are in and published we should open a similar PR in dask-feedstock to cut a new release of the dask metapackage

Ah! Missed that, sorry, but I see you're doing it in conda-forge/dask-feedstock#274, thanks for addressing that.

@charlesbluca
Copy link
Member

built in sequential order (dask-core, distributed, dask)

I was incorrect here, I'm forgetting dask-expr which is a dependency of the metapackage and hard pinned to a specific dask-core version, so the order is actually:

  • dask-core
  • distributed and dask-expr in parallel
  • dask [metapackage]

@pentschev
Copy link
Member

Nice catch, I didn't realize there has been a dask-expr release as well since it doesn't follow the same calver and wasn't mentioned here.

@charlesbluca
Copy link
Member

Opened a PR for dask-expr: conda-forge/dask-expr-feedstock#79

I'm not a maintainer there so will need to wait until that gets approved for us to complete the conda-forge release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants