Skip to content

Commit da330e0

Browse files
committed
refactor: remove code duplication
1 parent b116fc6 commit da330e0

File tree

1 file changed

+11
-15
lines changed

1 file changed

+11
-15
lines changed

test/functional/feature_governance_cl.py

Lines changed: 11 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -136,21 +136,17 @@ def run_test(self):
136136
self.bump_mocktime(156)
137137
self.generate(self.nodes[0], 1, sync_fun=lambda: self.sync_blocks(self.nodes[0:5]))
138138

139-
self.log.info("Bump time to trigger governance cleanup")
140-
# Trigger scheduler to mark old triggers for deletion
141-
delta = 5 * 60
142-
self.mocktime += delta
143-
for node in self.nodes:
144-
with node.assert_debug_log(expected_msgs=['UpdateCachesAndClean']):
145-
node.setmocktime(self.mocktime)
146-
node.mockscheduler(delta)
147-
# Move forward to satisfy GOVERNANCE_DELETION_DELAY, should actually remove old triggers now
148-
delta = 10 * 60
149-
self.mocktime += delta
150-
for node in self.nodes:
151-
with node.assert_debug_log(expected_msgs=['UpdateCachesAndClean -- Governance Objects: 0']):
152-
node.setmocktime(self.mocktime)
153-
node.mockscheduler(delta)
139+
self.log.info("Bump mocktime to trigger governance cleanup")
140+
for delta, expected in (
141+
(5 * 60, ['UpdateCachesAndClean']), # mark old triggers for deletion
142+
(10 * 60, ['UpdateCachesAndClean -- Governance Objects: 0']), # deletion after delay
143+
):
144+
self.mocktime += delta
145+
for node in self.nodes:
146+
with node.assert_debug_log(expected_msgs=expected):
147+
node.setmocktime(self.mocktime)
148+
node.mockscheduler(delta)
149+
154150
# Confirm in RPC
155151
for node in self.nodes:
156152
assert_equal(len(node.gobject("list", "valid", "triggers")), 0)

0 commit comments

Comments
 (0)