refactor: consolidate CFinalCommitmentPtr definitions

Author: kwvg

src/llmq/commitment.h

@@ -5,13 +5,15 @@
 #ifndef BITCOIN_LLMQ_COMMITMENT_H
 #define BITCOIN_LLMQ_COMMITMENT_H
 
-#include <bls/bls.h>
-#include <llmq/params.h>
 #include <primitives/transaction.h>
 #include <util/irange.h>
 #include <util/strencodings.h>
 #include <util/underlying.h>
 
+#include <bls/bls.h>
+#include <llmq/params.h>
+#include <llmq/types.h>
+
 #include <gsl/pointers.h>
 #include <univalue.h>
 
@@ -156,7 +158,6 @@ class CFinalCommitment
         return HexStr(vBytes);
     }
 };
-using CFinalCommitmentPtr = std::unique_ptr<CFinalCommitment>;
 
 class CFinalCommitmentTxPayload
 {

src/llmq/quorums.h

@@ -170,10 +170,6 @@ class CQuorumDataRequest
  * the public key shares of individual members, which are needed to verify signature shares of these members.
  */
 
-class CFinalCommitment;
-using CFinalCommitmentPtr = std::unique_ptr<CFinalCommitment>;
-
-
 class CQuorum
 {
     friend class CQuorumManager;

src/llmq/types.h

@@ -14,6 +14,7 @@ class CDeterministicMN;
 class uint256;
 struct StaticSaltedHasher;
 namespace llmq {
+class CFinalCommitment;
 class CQuorum;
 } // namespace llmq
 
@@ -26,6 +27,7 @@ template <typename T, size_t MaxSize = 0ul, size_t TruncateThreshold = 0ul>
 using Uint256LruHashMap = unordered_lru_cache<uint256, T, StaticSaltedHasher, MaxSize, TruncateThreshold>;
 
 namespace llmq {
+using CFinalCommitmentPtr = std::unique_ptr<CFinalCommitment>;
 using CQuorumPtr = std::shared_ptr<CQuorum>;
 using CQuorumCPtr = std::shared_ptr<const CQuorum>;
 } // namespace llmq