-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactoring, some bug fixes and increased test coverage #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsiedentop
changed the title
add more tests
refactoring, some bug fixes and increased test coverage
Feb 28, 2024
The questions have been solved during the refactoring. Comparing geometries with a different amount of points should always result in not being equal. The test cases in which the behavior deviated from expectations were simply bugs. Therefore, I am merging this to master so that we can release a new version for dartclub/turf_dart#174 soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some more lineString tests. There are two test cases where at least one is not behaving as expected:
I compare two lines with same start and end point but ...
I would expect, that booth cases are equal or not equal depending on the understanding of equality. Are the lines only equal, if they have exactly the same structure or is it enough if they have the same shape?
@lukas-h