Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactoring, some bug fixes and increased test coverage #13

Merged
merged 12 commits into from
Feb 28, 2024

Conversation

jsiedentop
Copy link
Contributor

I've added some more lineString tests. There are two test cases where at least one is not behaving as expected:

I compare two lines with same start and end point but ...

  • one line has a third point in the middle -> The lines are recognized as not equal.
  • one line has the same end point twice -> The lines are recognized as equal.

I would expect, that booth cases are equal or not equal depending on the understanding of equality. Are the lines only equal, if they have exactly the same structure or is it enough if they have the same shape?

@lukas-h

@jsiedentop jsiedentop self-assigned this Feb 14, 2024
@jsiedentop jsiedentop linked an issue Feb 25, 2024 that may be closed by this pull request
@jsiedentop jsiedentop changed the title add more lineString tests add more tests Feb 25, 2024
@jsiedentop jsiedentop changed the title add more tests refactoring, some bug fixes and increased test coverage Feb 28, 2024
@jsiedentop jsiedentop requested a review from lukas-h February 28, 2024 10:45
@jsiedentop jsiedentop marked this pull request as ready for review February 28, 2024 10:46
@jsiedentop jsiedentop removed the request for review from lukas-h February 28, 2024 10:46
@jsiedentop
Copy link
Contributor Author

The questions have been solved during the refactoring. Comparing geometries with a different amount of points should always result in not being equal. The test cases in which the behavior deviated from expectations were simply bugs. Therefore, I am merging this to master so that we can release a new version for dartclub/turf_dart#174 soon.

@jsiedentop jsiedentop merged commit defff8f into dartclub:main Feb 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant