Skip to content

Commit 55de977

Browse files
authored
Update and simplify deploy image (#253)
- Updates the image to the latest Dart beta. - Removes Node and NPM as the sites no longer rely on them to build. - Use the [Firebase standalone binary install](https://firebase.google.com/docs/cli#mac-linux-auto-script) rather than installing it through NPM.
1 parent 3b05749 commit 55de977

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed
Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM dart:3.10.0-290.4.beta
1+
FROM dart:3.11.0-93.2.beta
22

33
# Install prerequisite dependencies.
44
RUN apt-get update && apt-get install -y curl gpg
@@ -8,13 +8,5 @@ RUN curl -fsSL https://cli.github.com/packages/githubcli-archive-keyring.gpg | g
88
RUN echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/githubcli-archive-keyring.gpg] https://cli.github.com/packages stable main" | tee /etc/apt/sources.list.d/github-cli.list > /dev/null;
99
RUN apt update && apt install -y gh;
1010

11-
# Install the latest LTS of Node, which also includes npm.
12-
RUN mkdir -p /etc/apt/keyrings
13-
RUN curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg
14-
ENV NODE_MAJOR=22
15-
RUN echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_$NODE_MAJOR.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list
16-
RUN apt-get update
17-
RUN apt-get install nodejs -y
18-
1911
# Install the latest version of firebase-tools globally.
20-
RUN npm install -g firebase-tools
12+
RUN curl -sL https://firebase.tools | bash

cloud_build/firebase-ghcli/README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
## Summary
22

33
This directory contains a Dockerfile that provides access to
4-
Dart, Node/NPM, Firebase CLI tools, and the GitHub CLI.
4+
Dart, Firebase CLI tools, and the GitHub CLI.
55
This image is used to deploy various Dart/Flutter websites to
66
Firebase in both production and staging, and is
77
also used to comment staging links on GitHub PRs.
@@ -10,7 +10,6 @@ also used to comment staging links on GitHub PRs.
1010

1111
* Dart SDK
1212
* GitHub CLI
13-
* Node/NPM
1413
* Firebase Tools
1514

1615
## Additional information

0 commit comments

Comments
 (0)