Skip to content

[js_runtime] corelib{,_2}/growable_list_test - JSArray.addAll checks ConcurrentModificationError in assert #48619

Open
@rakudrama

Description

@rakudrama

JSArray.addAll checks for a ConcurrentModificationError in a assert.

As a consequence, the tests

corelib_2/growable_list_test RuntimeError
corelib/growable_list_test RuntimeError

are failing on configurations that run without asserts enabled.

I think it is reasonable for a CME check for an unlikely case to be checked in an assertion rather than in production.
We should assess if moving the CME check to an assert was beneficial for performance, and whether we have good test coverage for assert-based checks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-web-jsIssues related to JavaScript support for Dart Web, including DDC, dart2js, and JS interop.dart2js-runtime-libraryIssues related to runtime library for dart2js (sdk/lib/_internal/js_runtime)web-dart2js

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions