Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle multi-language epub/pdfs #276

Open
elstoc opened this issue Jun 4, 2021 · 4 comments
Open

handle multi-language epub/pdfs #276

elstoc opened this issue Jun 4, 2021 · 4 comments
Milestone

Comments

@elstoc
Copy link
Contributor

elstoc commented Jun 4, 2021

epub and pdf files in the translated site contain a mixture of English and translated pages. We will need to change these so that they are generated per-language (or just English for now).

@elstoc elstoc added this to the 3.6 milestone Jun 4, 2021
@elstoc
Copy link
Contributor Author

elstoc commented Jun 5, 2021

For now I've moved the translation generation step in the CI until after the epub and pdfs have been generated but this will need to be addressed when the translations are complete.

@elstoc elstoc changed the title epub and pdf are mixed-language handle multi-language epub/pdfs Jun 12, 2021
@elstoc elstoc modified the milestones: 3.6, 3.8 Jun 12, 2021
@paperdigits
Copy link
Contributor

I think we might need a little piece of config for each language to make that particular language the default...

@paperdigits
Copy link
Contributor

the PDF renders using our current setup, but the images do not. The links to the images have the language code in the URL, but they should all point to the "English" image.

@elstoc
Copy link
Contributor Author

elstoc commented Nov 1, 2021

We fixed this for the main site some time ago so it should be simple enough to port that fix to the pdf. The epub might be more problematic, since we need the images to be physically present in the rendered epub.

I think we'd rather have a pdf/epub for each language rather than a single multilingual pdf/epub (or I would anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants