-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detail mask crashing the app, requiring clearing the history of photo that uses it #17897
Comments
It seems you have set tune for headroom manually, this leaves just ~600MB for system use. On wayland with firefox or other apps using the graphics memory this is likely on the too-small side. |
@jenshannoschwalm I'm getting the same issue with 5.0.0 on Windows. One image with Enlarge Canvas is causing Darktable to crash 100% of the time. Is there a setting I need to modify or should I submit a bug report? I'm not seeing an option to change the headroom in settings, other than to "Use all GPU memory", but this does not prevent the crashes. |
You might do a log with '-d pipe '-d opencl' and also share raw and xmp. |
There have been fixes lately so you should also try the nightly builds. After that feel free to come back :-) and we'll see if some new issue. |
Thanks @jenshannoschwalm! Attached a log file after -d pipe -d opencl RAW and XMP: https://1drv.ms/u/c/abaaa8177e4359be/EfIPJzYgw4dGh_Bd5Ilxns4Bu_miZc4jRe9l__HwRdlR3A?e=PzmGgy |
Thanks. Confirmed here on nvidia but also with disabled opencl. |
This is not an enlarge canvas issue to me but a crash due to a detail mask. Disabling both contrast equalizer and d&s where a detail mask is used fixes the crash. Just enabling contrast equalizer crash again. |
Well, just disabling the enlarge canvas also avoids the crash. Seems to be the combination, will take care. |
I had assumed it was because of Expand Canvas because the image causing the crash is the only image I have ever used Expand Canvas on. But if it's of any note, I have been getting "detail mask error" notifications when loading albums in the Lighttable for the first time. This seems to be a new issue since upgrading to 5.0.0, although I'm not sure if the error itself is new or just the reporting of the error. I use detail masks extensively. Let me know if you want me to do any testing. |
I know already whats wrong, ita about tiling and Details. |
The above mentioned PR only fixes the details mask writing being totally wrong because of running in tiled mode. BUT: there are still issues like this
Not sure yet if this is a problem in enlargecanvas "mask distorting". |
Describe the bug
Using the Expand Canvas module crashes the app, especially in combination with cropping
Steps to reproduce
Expected behavior
not crash
Logfile | Screenshot | Screencast
^ The munmap_chunk bit showed up when it started rendering the image with the module enabled
Commit
No response
Where did you obtain darktable from?
flatpak
darktable version
4.8.1
What OS are you using?
Linux
What is the version of your OS?
openSUSE Tumbleweed, Gnome 47, Wayland
Describe your system?
32 GB Ram
AMD Ryzen 9 7900X3D
GNOME 47
Wayland
Are you using OpenCL GPU in darktable?
Yes
If yes, what is the GPU card and driver?
RTX 3070 Ti
Please provide additional context if applicable. You can attach files too, but might need to rename to .txt or .zip
No response
The text was updated successfully, but these errors were encountered: