inline: false and external: [] causes invalid syntax with multiple outputs

[mattrossman]

Given this rollup configuration:

import webWorker from "rollup-plugin-web-worker-loader";

/** @type {import('rollup').RollupOptions} */
export default {
    input: "src/index.js",
    output: [
        {
            file: "dist/index.js",
            format: "cjs",
        },
        {
            file: "dist/index.modern.js",
            format: "es",
        },
    ],
    plugins: [
        webWorker({
            targetPlatform: "browser",
            inline: false,
            external: [],
        }),
    ],
};

This plugin tries to write both rollup outputs to the same destination index.modern.js. This results in a file that is a mixture of CJS and ESM, an invalid syntax that causes errors.

It seems this is because the plugin holds a single mutable filename reference in state.configuredFileName

rollup-plugin-web-worker-loader/src/index.js

Lines 37 to 46 in 48df453

	const state = {
	idMap: new Map(),
	exclude: new Set(),
	outFiles: new Map(),
	options: null,
	basePath: null,
	forceInlineCounter: 0,
	configuredFileName: null,
	};

This mutable value is used as the output destination, which is unstable.

rollup-plugin-web-worker-loader/src/plugin/outputOptions.js

Lines 3 to 12 in 48df453

	function outputOptions(state, config, options) {
	if (!config.inline && options.file && !options.dir) {
	state.configuredFileName = path.basename(options.file);
	return Object.assign({}, options, {
	file: null,
	dir: path.dirname(options.file),
	});
	}
	return null;
	}

I will try to make a PR fix.

[mattrossman]

Not familiar with writing rollup plugins but I find it strange that options.file is null in generateBundle but not in outputOptions. It seems difficult to lookup the original configured file value for each output in the generateBundle phase. The only unique data I can see is the options.format. I can't remember if rollup lets you define multiple outputs with the same format, but for now I will just pretend each format is a unique output so I can look up the file name from a Map.