Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreshWt.OUT #16

Open
osherboudara-work opened this issue Sep 11, 2023 · 4 comments
Open

FreshWt.OUT #16

osherboudara-work opened this issue Sep 11, 2023 · 4 comments

Comments

@osherboudara-work
Copy link

Hello again @daquinterop!
I wanted to reach out and ask about model outputs. Currently, in this package, the model outputs the 'PlantGro', 'Weather', 'SoilWat', 'SoilOrg' output files from DSSAT. I noticed that DSSAT has a FreshWt.Out file which contains the fresh fruit weight data. Is it possible to add this output file in your package? I know we previously discussed here on how to obtain fresh weight for tomatoes. If this file can be outputted in this package, it would help me with this issue.

Here is the link to where I spotted the output file. It is on line 31:
https://github.com/DSSAT/dssat-csm-os/blob/develop/Data/OUTPUT.CDE

Thank you for all your previous help and for this amazing package! It has been of great use thus far!

@daquinterop
Copy link
Owner

Hello @osherboudara-work

That's completely new information for me, thanks for sharing this!! Sure, I'll look at how the model generates that output and I'll include it. As of now I just saw that that output file is always generated for vegetables regardless of the output options. So you can read it as you would read a regular text file using python.

@osherboudara-work
Copy link
Author

Sounds good! I'll check the DSSAT tmp directory and see if I can take a look at that output. Keep me posted on whether this addition is possible in the future. Thanks again!

@osherboudara-work
Copy link
Author

osherboudara-work commented Dec 20, 2023

Hello @daquinterop ! I wanted to follow up on this issue.

I have been extracting the data from the FreshWt.Out file generated by this library as suggested above.

I have also been using the DSSAT GUI to run a few simulations and I noticed that the FreshWt.OUT file has many differences in the data reported compared to what is generated from this library. There are alot more columns in the DSSAT GUI FreshWt.OUT than there is in this package.

I believe this is due to some updates to the original DSSAT package that this library does not contain. Is my assumption correct on this? If not, how would I go about generating those other variables (I have attached a screenshot of the variables contained in the file below)? Additionally, if this library is not using the most updated version of DSSAT (I think its using 4.8.0.028), can it be updated to the newest version (4.8.2.0)?

Thank you for all your great work on this library!
image

@daquinterop
Copy link
Owner

Hi @osherboudara-work , your explanation totally makes sense. Furthermore the DSSAT executable that the library uses was compiled from the main DSSAT repository, so probably it doesn't match the one that DSSAT GUI uses. However, I've been working on implementing the same version used by the latest DSSAT GUI release, which is 4.8.2 I think. At the moment, I'm working on testing the different crops by running one of the DSSAT GUI experiments and comparing the results to make sure that the outputs are the same, or similar within some tolerance.

Thanks for reaching out, I'll let you know when I finish those updates I'm telling you about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants