Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong commands in Hello-Kubernetes Tutorial #944

Open
msfussell opened this issue Oct 4, 2023 · 4 comments
Open

Wrong commands in Hello-Kubernetes Tutorial #944

msfussell opened this issue Oct 4, 2023 · 4 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@msfussell
Copy link
Member

msfussell commented Oct 4, 2023

Bugs in this tutorial when observing logs for nodeapp
https://github.com/dapr/quickstarts/tree/master/tutorials/hello-kubernetes

This
kubectl logs --selector=app=node -c node --tail=-1
should be
kubectl logs --selector=app=nodeapp -c nodeapp --tail=-1

And this
kubectl logs --selector=app=node -c daprd --tail=-1
should be
kubectl logs --selector=app=nodeapp -c daprd --tail=-1

And this
kubectl logs --selector=app=python -c daprd --tail=-1
should be
kubectl logs --selector=app=pythonapp -c daprd --tail=-1

Check any missing occurences in the rest of the tutorial

@msfussell msfussell added the good first issue Good for newcomers label Oct 4, 2023
@Titanpimpale
Copy link

Hello @msfussell I would love to make changes to the above tutorial and also if I find any missing occurrence in the project I will fix that also please assign it to me !!!

@msfussell
Copy link
Member Author

Assigned!

@dasanind
Copy link

@Titanpimpale Are you working on this?

@pdebruin
Copy link
Contributor

Hi @msfussell, I just looked at this. It looks like this works as is today (and the proposed changes don't). What was the source of this proposed change? Else I suggest to close this issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants