Allow infinite retries for workflows#935
Conversation
acroca
left a comment
There was a problem hiding this comment.
Also, I think it'd be useful to add a scenario for the infinite retries to the examples/workflow/simple.py. The example could be just a counter that makes it fail 10 times, and succeed after all those failures, and assert the workflow completed successfully. makes sense?
828611a to
95feef7
Compare
|
I adjusted the WorkflowRuntime start time so it doesn't fail when the worker isn't ready within the expected time. |
|
Thanks! |
| self._logger.warning( | ||
| 'WorkflowRuntime worker and its stream are not ready. ' | ||
| 'Continuing; workflows scheduled immediately may not be received.' | ||
| ) |
There was a problem hiding this comment.
Hm do you mind explaining this change? I feel it'd be good to raise an an error because the worker is not ready.
There was a problem hiding this comment.
It was due to a pipeline error, where the attempts were altered.
|
I apologize, I thought I had to do a squash commit. |
|
pr a pipeline tb failed again, I don't understand the error. |
|
Hi! 👋 can you try running these cmds pls to fix the DCO build step? |
…lows (dapr#931) Signed-off-by: Albert Callarisa <albert@diagrid.io> Signed-off-by: Matheus André <92062874+matheusandre1@users.noreply.github.com>
Signed-off-by: Matheus André <92062874+matheusandre1@users.noreply.github.com>
Signed-off-by: Matheus André <92062874+matheusandre1@users.noreply.github.com>
Signed-off-by: Matheus André <92062874+matheusandre1@users.noreply.github.com>
|
@matheusandre1 can you address the comments? |
|
@CasperGN I didn't understand, I corrected what was requested. |
|
@CasperGN , I'm having trouble understanding the CI errors; check examples. |
Sorry I wasn't explicit enough. There's a couple of test failures that looks related to the infinite retries. The problem is deeper though: If you note the last line, the value error is thrown from durable task so this PR cannot be alone - it needs to follow with a PR in durable task that allow propagating Would it also be possible, when you get both repo PRs ready, to run it locally with an example of infinite retries? |
Description
I added the requested validation and created the test according to the project's naming convention.
Issue reference
Please reference the issue this PR will close: #870