Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper methods to propagate trace headers #434

Open
danielgerlag opened this issue Jan 5, 2023 · 3 comments
Open

Helper methods to propagate trace headers #434

danielgerlag opened this issue Jan 5, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@danielgerlag
Copy link

Add helper methods to propagate trace headers from an incoming invoke request or pub sub message to an outgoing invocation or pub sub message.

@danielgerlag
Copy link
Author

danielgerlag commented Jan 7, 2023

In order to make my scenario work, I had to create an alternative implementation of the pubsub client that allows the trace headers to be set.

@XavierGeerinck
Copy link
Contributor

Hi @danielgerlag ! Thank you for opening a ticket, seeing that you created an alternative implementation, would you have some time to share what you did? Maybe through a PR?

@XavierGeerinck XavierGeerinck added enhancement New feature or request good first issue Good for newcomers labels Jan 10, 2023
@DarqueWarrior
Copy link
Contributor

Would this be as easy as having an optional headers parameter for all the clients? That could then be passed to the base class execute method. There is already code in HTTPClient.ts to read the headers if they are provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants