chore: Fix review comments

Signed-off-by: Javier Aliaga <javier@diagrid.io>

Author: javier-aliaga

durabletask-client/src/main/java/io/dapr/durabletask/RetryPolicy.java

@@ -191,7 +191,7 @@ public Duration getRetryTimeout() {
    * @throws IllegalArgumentException if {@code jitterFactor} is outside [0.0, 1.0]
    */
   public RetryPolicy setJitterFactor(double jitterFactor) {
-    if (jitterFactor < 0.0 || jitterFactor > 1.0) {
+    if (!Double.isFinite(jitterFactor) || jitterFactor < 0.0 || jitterFactor > 1.0) {
       throw new IllegalArgumentException("The value for jitterFactor must be between 0.0 and 1.0 inclusive.");
     }
     this.jitterFactor = jitterFactor;

durabletask-client/src/main/java/io/dapr/durabletask/TaskOrchestrationExecutor.java

@@ -1504,7 +1504,7 @@ private Duration getNextDelay() {
                 (long) Helpers.powExact(this.policy.getBackoffCoefficient(), this.attemptNumber));
           } catch (ArithmeticException overflowException) {
             if (maxDelayInMillis > 0) {
-              return this.policy.getMaxRetryInterval();
+              nextDelayInMillis = maxDelayInMillis;
             } else {
               // If no maximum is specified, just throw
               throw new ArithmeticException("The retry policy calculation resulted in an arithmetic "

durabletask-client/src/test/java/io/dapr/durabletask/RetryPolicyTest.java

@@ -68,6 +68,18 @@ void jitterFactorAboveOneThrows() {
     assertThrows(IllegalArgumentException.class, () -> policy.setJitterFactor(1.1));
   }
 
+  @Test
+  void jitterFactorNaNThrows() {
+    RetryPolicy policy = new RetryPolicy(3, Duration.ofSeconds(1));
+    assertThrows(IllegalArgumentException.class, () -> policy.setJitterFactor(Double.NaN));
+  }
+
+  @Test
+  void jitterFactorPositiveInfinityThrows() {
+    RetryPolicy policy = new RetryPolicy(3, Duration.ofSeconds(1));
+    assertThrows(IllegalArgumentException.class, () -> policy.setJitterFactor(Double.POSITIVE_INFINITY));
+  }
+
   // ---- deterministic delay formula ----
 
   /**

sdk-workflows/src/main/java/io/dapr/workflows/WorkflowTaskRetryPolicy.java

@@ -26,6 +26,25 @@ public final class WorkflowTaskRetryPolicy {
   private final Duration retryTimeout;
   private final Double jitterFactor;
 
+  /**
+   * Constructor for WorkflowTaskRetryPolicy (without jitter).
+   * @param maxNumberOfAttempts Maximum number of attempts to retry the workflow.
+   * @param firstRetryInterval Interval to wait before the first retry.
+   * @param backoffCoefficient Coefficient to increase the retry interval.
+   * @param maxRetryInterval Maximum interval to wait between retries.
+   * @param retryTimeout Timeout for the whole retry process.
+   */
+  public WorkflowTaskRetryPolicy(
+      Integer maxNumberOfAttempts,
+      Duration firstRetryInterval,
+      Double backoffCoefficient,
+      Duration maxRetryInterval,
+      Duration retryTimeout
+  ) {
+    this(maxNumberOfAttempts, firstRetryInterval, backoffCoefficient,
+        maxRetryInterval, retryTimeout, null);
+  }
+
   /**
    * Constructor for WorkflowTaskRetryPolicy.
    * @param maxNumberOfAttempts Maximum number of attempts to retry the workflow.
@@ -200,7 +219,7 @@ public Builder setRetryTimeout(Duration retryTimeout) {
      * @return This builder
      */
     public Builder setJitterFactor(double jitterFactor) {
-      if (jitterFactor < 0.0 || jitterFactor > 1.0) {
+      if (!Double.isFinite(jitterFactor) || jitterFactor < 0.0 || jitterFactor > 1.0) {
         throw new IllegalArgumentException("The value for jitterFactor must be between 0.0 and 1.0 inclusive.");
       }
 

sdk-workflows/src/test/java/io/dapr/workflows/WorkflowTaskRetryPolicyTest.java

@@ -87,6 +87,18 @@ void jitterFactorAboveOneThrows() {
     assertThrows(IllegalArgumentException.class, () -> builder.setJitterFactor(1.1));
   }
 
+  @Test
+  void jitterFactorNaNThrows() {
+    WorkflowTaskRetryPolicy.Builder builder = WorkflowTaskRetryPolicy.newBuilder();
+    assertThrows(IllegalArgumentException.class, () -> builder.setJitterFactor(Double.NaN));
+  }
+
+  @Test
+  void jitterFactorPositiveInfinityThrows() {
+    WorkflowTaskRetryPolicy.Builder builder = WorkflowTaskRetryPolicy.newBuilder();
+    assertThrows(IllegalArgumentException.class, () -> builder.setJitterFactor(Double.POSITIVE_INFINITY));
+  }
+
   // ---- builder chaining ----
 
   @Test