Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize ParseHex function #12

Open
dansmith65 opened this issue Apr 13, 2015 · 1 comment
Open

optimize ParseHex function #12

dansmith65 opened this issue Apr 13, 2015 · 1 comment
Labels
enhancement

Comments

@dansmith65
Copy link
Owner

It shouldn't have to recurse to do it's job.

May also want to put the code right in the ParseString function since that's the only place it's called from.
@dansmith65
Copy link
Owner Author

When I do this, I should add tests for max input data length to confirm the code changes increase this length, as it should. The tests should also run faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dansmith65