Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shouldUseRouter() always return true #42

Closed
kwolniak opened this issue Mar 7, 2022 · 0 comments · Fixed by #43
Closed

shouldUseRouter() always return true #42

kwolniak opened this issue Mar 7, 2022 · 0 comments · Fixed by #43

Comments

@kwolniak
Copy link

kwolniak commented Mar 7, 2022 •
edited
Loading

In source code we can find

const DEFAULT_USE_ROUTER = true

and

function shouldUseRouter(moduleOptions, $config) {
  return moduleOptionRouter(moduleOptions) || configOptionRouter($config) || DEFAULT_USE_ROUTER
}

shouldUseRouter() always return true because of DEFAULT_USE_ROUTER, so SEGMENT_USE_ROUTER config is useless.
@kwolniak kwolniak changed the title shouldUseRouter() return always true shouldUseRouter() always return true Mar 7, 2022
@fabiofdsantos fabiofdsantos mentioned this issue Mar 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: shouldUseRouter() always return true
1 participant
@kwolniak