Use mock keychain on macOS to suppress Safe Storage dialog#17
Merged
Conversation
The `password-store=basic` switch is a no-op on macOS — OSCrypt always uses the Keychain there regardless of the flag, so the "GitGrove Safe Storage" password dialog kept appearing on ad-hoc-signed builds. Add `use-mock-keychain` on darwin so OSCrypt uses an in-process mock keychain and never touches the real one. GitGrove keeps no secrets (recents are plaintext JSON), so this is safe. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On macOS, the
password-store=basicswitch is a no-op — Chromium's OSCrypt always uses the Keychain there regardless of the flag. That's why the "GitGrove wants to use your confidential information" / Safe Storage password dialog kept appearing on every launch of ad-hoc-signed builds (each version gets a fresh code signature, so the keychain ACL never matches and the grant can't persist).This adds
use-mock-keychainon darwin, which makes OSCrypt use an in-process mock keychain and never touch the real one. Verified: with it set, the "GitGrove Safe Storage" Keychain entry is no longer created or read.GitGrove keeps no secrets (recents are plaintext JSON), so opting out of the OS secret store is safe.
Changes
use-mock-keychainswitch whenprocess.platform === 'darwin'.🤖 Generated with Claude Code