From ec8fb7b527004edf092df98fe3dddeafc2ad35b3 Mon Sep 17 00:00:00 2001 From: Daniel Rozenberg Date: Thu, 20 Apr 2023 12:34:50 -0400 Subject: [PATCH] Explicitly set `ORB_PARAM_CHROME_VERSION` env variable in shell script (workaround for https://github.com/CircleCI-Public/browser-tools-orb/issues/70) --- .circleci/config.yml | 2 +- .circleci/get_pinned_chrome_version.sh | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index c5b70e2c0f6f..1f8948df38a9 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -133,7 +133,7 @@ commands: name: 'Get Pinned Chrome Version' command: ./.circleci/get_pinned_chrome_version.sh - browser-tools/install-chrome: - chrome-version: ${CHROME_VERSION} + # chrome-version is set in ./.circleci/get_pinned_chrome_version.sh, see files for details. replace-existing: true - browser-tools/install-chromedriver install_firefox: diff --git a/.circleci/get_pinned_chrome_version.sh b/.circleci/get_pinned_chrome_version.sh index b9c6eaec97ab..51b6ff9b3445 100755 --- a/.circleci/get_pinned_chrome_version.sh +++ b/.circleci/get_pinned_chrome_version.sh @@ -49,5 +49,6 @@ echo "$(GREEN "Determining Chrome version...")" CHROME_VERSION="$(curl -sS --retry 3 ${CHROME_VERSION_HISTORY_URL} | jq -r ".versions[]|.version" | grep -m 1 "${CHROME_MAJOR_VERSION}\.[[:digit:]]\+.[[:digit:]]\+.[[:digit:]]\+")" echo "$(GREEN "Chrome version is") $(CYAN "${CHROME_VERSION}")" -echo "export CHROME_VERSION=$CHROME_VERSION" >> $BASH_ENV +# Workaround for https://github.com/CircleCI-Public/browser-tools-orb/issues/70 +echo "export ORB_PARAM_CHROME_VERSION=$CHROME_VERSION" >> $BASH_ENV echo $(GREEN "Successfully determined pinned version of Chrome")