Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

danger.git.diffForFile only seems to work when DANGER_GITHUB_API_TOKEN is set #454

Open
grxy opened this issue Aug 12, 2019 · 2 comments
Open

Comments

@grxy
Copy link

grxy commented Aug 12, 2019

Hi! I really appreciate the time you've invested into danger and peril. It has been extremely valuable to me and many teams I've been on.

When I try to run danger.git.diffForFile in a PR, the diff object is resolved to null, unless I set DANGER_GITHUB_API_TOKEN with a personal access token in heroku. Is this by design, or is there some config/setup that I possibly missed so that peril has access to retrieve a diff for a file in a PR?

Thanks!

@orta
Copy link
Member

orta commented Aug 12, 2019

Is it possible you have an old install of peril, think that got fixed recently ( #367 (comment) )

@grxy
Copy link
Author

grxy commented Aug 12, 2019

Unfortunately, no. This is from a new Peril setup I worked on right before creating this ticket just yesterday. I followed the setup_for_org instructions.

For context, this was my second attempt at solving this in the last month or so. All diffs for another peril setup are returning null as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants