Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 module needs exporting #117

Open
Heverett94 opened this issue Jul 29, 2020 · 4 comments
Open

ES6 module needs exporting #117

Heverett94 opened this issue Jul 29, 2020 · 4 comments
Labels
dependencies Pull requests that update a dependency file Design Improvements Improvements or fixes to any web designs

Comments

@Heverett94
Copy link
Collaborator

Description

ES6 module needs exporting to allow testing.

Steps to reproduce

The actual vs expected behaviour

At the moment functions are out of scope and unaccessable i believe this is due to the import statement for guage.js.

Additional Information

@Heverett94 Heverett94 added the Design Improvements Improvements or fixes to any web designs label Jul 29, 2020
@dambem
Copy link
Owner

dambem commented Jul 29, 2020

Yes! This was the issue. I managed to sort of hot-fix it by appending var to necessary functions to force them into a global scope but obviously not the best shot. Thank you for finding this I was wondering what was causing it!

@Heverett94
Copy link
Collaborator Author

Heverett94 commented Jul 29, 2020

Might work having it all in a class then define the class as a variable on a global scope. Then export class.blah instead of varing it all?

@dambem
Copy link
Owner

dambem commented Jul 31, 2020

@AlvaroRausell
Copy link
Collaborator

We had a shot at ES6'ing the gauge code, but the issue is that importing it then to a ES5 codebase (new_mapping.js) gave us lots of problems. How necessary are the tests to the gauge?

@M-Davies M-Davies added the dependencies Pull requests that update a dependency file label Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Design Improvements Improvements or fixes to any web designs
Projects
None yet
Development

No branches or pull requests

4 participants