-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Does not work in reusable workflows #5
Comments
Thanks @qoomon |
Ok. I see what you're talking about. One caveat of a reusable workflow is that the You pretty much said what is needed to make it work. Set your Unless you have a better proposal, I may opt to just adding documentation of how to use the action when inside of a |
Also see my PR to fix this problem in the github action runner actions/runner#3489 |
Can you give me the TL;DR? I'm still not sure what your actual recommendation is. Is this If it's easier to submit a PR here, or paste a code snippet in the context of this repo, I can certainly look at it. |
@jeremy-daley-kr actions/runner#3489 is the PR. Not Short, sadly too long full detail version: Up to this point it seems like a quality of life issue not necessarily a bug... But... Since the system.jobId contains a GUID that is not present in job api endpoint, the only unique identifier is the JOB name. The issue becomes apparent when you apply a matrix or reusable workflow: (Since the is the only guaranteed data shared between the job level api and the github.job context) Something similar was added for the Telemetry. |
the job id can not be determined if the action is part of a reusable workflow.
The problem seems to be that the actual job name is something like
<main workflow job> / <reusable workflow job>
The text was updated successfully, but these errors were encountered: