From fa7b86c1c9e50cb70abd53a1f9101d3376821a35 Mon Sep 17 00:00:00 2001 From: Daithi Hearn Date: Thu, 2 Feb 2023 20:38:02 +0100 Subject: [PATCH 1/2] Improving Single Leaderboard layout --- .../Leaderboard/SinglesLeaderboard.tsx | 25 ++++++++----------- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/src/components/Leaderboard/SinglesLeaderboard.tsx b/src/components/Leaderboard/SinglesLeaderboard.tsx index 599e204..d757cb9 100644 --- a/src/components/Leaderboard/SinglesLeaderboard.tsx +++ b/src/components/Leaderboard/SinglesLeaderboard.tsx @@ -66,15 +66,21 @@ const SinglesLeaderboard = () => { () => [ { name: "Avatar", + cell: row => ( + {row.name} + ), + }, + { cell: row => ( Image Preview ), + center: true, + omit: gameOver || !previousHand, }, - { name: "Player", selector: row => row.name, sortable: true }, { name: "Score", selector: row => row.score, @@ -105,17 +111,6 @@ const SinglesLeaderboard = () => { center: true, omit: !gameOver, }, - { - cell: row => ( - {row.previousCard} - ), - center: true, - omit: gameOver || !previousHand, - }, ], [gameOver, previousHand], ) From c01daacd229f86460aa4248b440ec190f68bd68d Mon Sep 17 00:00:00 2001 From: Daithi Hearn Date: Thu, 2 Feb 2023 20:38:27 +0100 Subject: [PATCH 2/2] Fixing bug whereby the game was resetting in an infinite loop --- src/pages/Game/Game.tsx | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/pages/Game/Game.tsx b/src/pages/Game/Game.tsx index 13795a0..7f0c4c9 100644 --- a/src/pages/Game/Game.tsx +++ b/src/pages/Game/Game.tsx @@ -38,18 +38,20 @@ const Game = () => { await dispatch(GameService.getAllPlayers()).catch((e: Error) => enqueueSnackbar(parseError(e), { variant: "error" }), ) - }, [iamSpectator]) + }, [id, iamSpectator]) useEffect(() => { fetchData() + }, [id, iamSpectator]) + useEffect(() => { return () => { - console.log("Resetting game") - dispatch(resetGame()) + console.log("Clearing game") dispatch(clearMyCards()) dispatch(clearAutoPlay()) + dispatch(resetGame()) } - }, [id, iamSpectator]) + }, []) return (