-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with wrapper, VASTAdTagURI and TrackingEvents #53
Comments
Actually, I just updated to the latest vast-client and it seems that that solves the issue. I’ll try to get The Onion to update their plugin to use a more recent version of vast-client. |
There is PR #50 on The Onion which will solve that. |
I think it's just that in the process they updated vast-client too. On Mon, Oct 27, 2014 at 5:41 AM, Alex Vasilenko [email protected]
|
Yeah, as The Onion PR will update vast-client to 1.3.0, which will solve this issue. |
Yeah, I understood this and deleted my comment :) |
Thought github has some delay before sending email notification |
@michaelvial is this fixed now? can we close? |
@rs Yes, it is. |
I’m trying to display an add in videojs using the onion vast plugin which uses vast-client. As soon as I have
<TrackingEvents>
, vast-client bombs saying for exampleUncaught TypeError: Cannot read property 'complete' of undefined
.If I remove the content of
<TrackingEvents>
, then everything works and the ad displays. Any ideas what could be going on?Here’s the XML I used:
The text was updated successfully, but these errors were encountered: