Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with wrapper, VASTAdTagURI and TrackingEvents #53

Closed
ghost opened this issue Oct 24, 2014 · 8 comments
Closed

Problem with wrapper, VASTAdTagURI and TrackingEvents #53

ghost opened this issue Oct 24, 2014 · 8 comments

Comments

@ghost
Copy link

ghost commented Oct 24, 2014

I’m trying to display an add in videojs using the onion vast plugin which uses vast-client. As soon as I have <TrackingEvents>, vast-client bombs saying for example Uncaught TypeError: Cannot read property 'complete' of undefined.

If I remove the content of <TrackingEvents>, then everything works and the ad displays. Any ideas what could be going on?

Here’s the XML I used:

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<VAST xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="vast.xsd" version="3.0">
  <Ad id="1">
    <Wrapper>
      <AdSystem>AdGear RTB</AdSystem>
      <VASTAdTagURI><![CDATA[http://ad3.liverail.com/?LR_PUBLISHER_ID=1331&LR_CAMPAIGN_ID=229&LR_SCHEMA=vast2#sthash.I98E97KQ.dpuf]]></VASTAdTagURI>
      <Impression><![CDATA[http://www.google.com]]></Impression>
      <Error><![CDATA[http://www.mytracker.com?vast3_error_[ERRORCODE].gif]]></Error>
      <Creatives>
        <Creative>
          <Linear>
            <TrackingEvents>
              <Tracking event="complete"><![CDATA[http://www.mytracker.com?complete.gif]]></Tracking>
              <Tracking event="firstQuartile"><![CDATA[http://www.mytracker.com?firstQuartile.gif]]></Tracking>
              <Tracking event="fullscreen"><![CDATA[http://www.mytracker.com?fullscreen.gif]]></Tracking>
              <Tracking event="midpoint"><![CDATA[http://www.mytracker.com?midpoint.gif]]></Tracking>
              <Tracking event="mute"><![CDATA[http://www.mytracker.com?mute.gif]]></Tracking>
              <Tracking event="pause"><![CDATA[http://www.mytracker.com?pause.gif]]></Tracking>
              <Tracking event="resume"><![CDATA[http://www.mytracker.com?resume.gif]]></Tracking>
              <Tracking event="rewind"><![CDATA[http://www.mytracker.com?rewind.gif]]></Tracking>
              <Tracking event="start"><![CDATA[http://www.mytracker.com?start.gif]]></Tracking>
              <Tracking event="thirdQuartile"><![CDATA[http://www.mytracker.com?thirdQuartile.gif]]></Tracking>
              <Tracking event="unmute"><![CDATA[http://www.mytracker.com?unmute.gif]]></Tracking>
            </TrackingEvents>
            <VideoClicks>
              <ClickTracking><![CDATA[http://www.mytracker.com?click.gif]]></ClickTracking>
            </VideoClicks>

          </Linear>
        </Creative>
      </Creatives>
    </Wrapper>
  </Ad>
</VAST>
@ghost
Copy link
Author

ghost commented Oct 24, 2014

Actually, I just updated to the latest vast-client and it seems that that solves the issue. I’ll try to get The Onion to update their plugin to use a more recent version of vast-client.

@briganti
Copy link
Contributor

There is PR #50 on The Onion which will solve that.

@ghost
Copy link
Author

ghost commented Oct 27, 2014

I think it's just that in the process they updated vast-client too.

On Mon, Oct 27, 2014 at 5:41 AM, Alex Vasilenko [email protected]
wrote:

@michaelvial how VPAID integration can fix issues with tracking?

Reply to this email directly or view it on GitHub:
#53 (comment)

@briganti
Copy link
Contributor

Yeah, as The Onion PR will update vast-client to 1.3.0, which will solve this issue.

@mente
Copy link
Contributor

mente commented Oct 27, 2014

Yeah, I understood this and deleted my comment :)

@mente
Copy link
Contributor

mente commented Oct 27, 2014

Thought github has some delay before sending email notification

@rs
Copy link
Contributor

rs commented Sep 13, 2015

@michaelvial is this fixed now? can we close?

@briganti
Copy link
Contributor

@rs Yes, it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants