Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't update submodule commit using Github API #348

Open
jashandeep-sohi opened this issue Aug 21, 2024 · 2 comments
Open

Can't update submodule commit using Github API #348

jashandeep-sohi opened this issue Aug 21, 2024 · 2 comments

Comments

@jashandeep-sohi
Copy link
Contributor

I'm using octopilot to update the commit that a submodule is at in the parent repo. This is done by using an exec updater and just running git commands manually to update the submodule commit, and then letting octopilot do the rest to create the commit. I know it's hacky, but it was working before #326.

The easiest fix for me would be to introduce a flag to force the commit to happen via pushChangesWithGit, but if you have better ideas, I'd be happy to implement that too.

@vbehar
Copy link
Collaborator

vbehar commented Sep 4, 2024

if you have better ideas, I'd be happy to implement that too.

this solution sounds good to me. thanks for fixing it!

@jashandeep-sohi
Copy link
Contributor Author

I added another PR to try to fix it using the API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants