feat(create-waku): --project-name option #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
rmarscher
commented
Feb 16, 2025
packages/create-waku/src/index.ts
Outdated
| onState: (state: any) => (targetDir = String(state.value).trim()), | ||
| onState: (state: any) => | ||
| (targetDir = | ||
| String(values['project-name']).trim() || |
There was a problem hiding this comment.
This might be unnecessary... checking...
There was a problem hiding this comment.
Yeah, removed the change from there.
There was a problem hiding this comment.
Do we still need this?
let targetDir = values['project-name'] || '';Or,
let targetDir = '';works?
There was a problem hiding this comment.
Yes, we still need that. Otherwise, it prompts for package name because targetDir is empty.
dai-shi
reviewed
Feb 17, 2025
packages/create-waku/src/index.ts
Outdated
| @@ -98,14 +101,14 @@ async function doPrompts() { | |||
| const templateNames = await getTemplateNames(templateRoot); | |||
|
|
|||
| const defaultProjectName = 'waku-project'; | |||
| let targetDir = ''; | |||
| let targetDir = values['project-name'] || ''; | |||
There was a problem hiding this comment.
Suggested change
| let targetDir = values['project-name'] || ''; | |
| let targetDir = values['project-name'] || defaultProjectName; |
and the change L119
- message: `${targetDir || defaultProjectName} is not empty. Remove existing files and continue?`,
+ message: `${targetDir} is not empty. Remove existing files and continue?`,work?
There was a problem hiding this comment.
Yes. I made this update and tested it. Looks good.
Open
dai-shi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1208