Add JSON output support for erk current command #616
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
schrockn
force-pushed
the
add-json-support-to-current-25-11-17
branch
from
a785d0b to
e269f48
Compare
schrockn
force-pushed
the
add-json-format-all-commands-25-11-17
branch
from
7e8b970 to
752cf37
Compare
Extends the `erk current` command with `--json` flag to output worktree information in machine-readable format. Enables automation tools and scripts to reliably extract current worktree details (name, path, is_root status) with strict schema validation. ## Files Changed ### Added - `src/erk/cli/json_schemas.py` CurrentCommandResponse class ### Modified - `src/erk/cli/commands/current.py` - Added --json flag and JSON response handling - `tests/commands/display/test_current.py` - Added 3 new JSON output tests ## Key Changes - New `CurrentCommandResponse` Pydantic schema (name, path, is_root fields) - `--json` flag routes output through JSON serialization layer - Refactored output logic to support both text and JSON formats - Full test coverage: worktree JSON, root worktree JSON, and schema validation ## Test Results All 1575 tests passing. CI validation complete.
schrockn
force-pushed
the
add-json-format-all-commands-25-11-17
branch
from
752cf37 to
d1799c4
Compare
schrockn
force-pushed
the
add-json-support-to-current-25-11-17
branch
from
e269f48 to
4bf62b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the
erk currentcommand with--jsonflag to output worktree information in machine-readable format. Enables automation tools and scripts to reliably extract current worktree details (name, path, is_root status) with strict schema validation.Files Changed
Added
src/erk/cli/json_schemas.pyCurrentCommandResponse classModified
src/erk/cli/commands/current.py- Added --json flag and JSON response handlingtests/commands/display/test_current.py- Added 3 new JSON output testsKey Changes
CurrentCommandResponsePydantic schema (name, path, is_root fields)--jsonflag routes output through JSON serialization layerTest Results
All 1575 tests passing. CI validation complete.