Make 'Ask AI' button font consistent with page #26620
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmpadden
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
When browsing Dagster's docs, I noticed that the "Ask AI" button's font seems to have a different font from the rest of the page. It seemed to use the default sans-serif font rather than the one in the theme. This is what it looked like on Chrome (v 131.0.6778.204 on Linux):
And on Firefox (v133.0.3, also on Linux):
It's a really minor thing, but I looked into the source code, saw TailwindCSS, and thought I might as well make a PR :)
How I Tested These Changes
I made changes in the browser inspector and verified that these changes look alright. I also ran the documentation website locally. Here's a screenshot of the result:
