[ruff] 0.3.0 -> 0.3.4 (#20753)

## Summary & Motivation

Internal companion PR: dagster-io/internal#8961

Bump ruff from 0.3.0 -> 0.3.4.

The major change here is a more aggressive UP032, which automatically
converts some str.format() calls to f-strings.

## How I Tested These Changes

Existing test suite.

Author: smackesey

.buildkite/dagster-buildkite/dagster_buildkite/steps/test_project.py

@@ -66,10 +66,8 @@ def build_test_project_steps() -> List[GroupStep]:
                 "docker push $${TEST_PROJECT_IMAGE}",
             )
             .on_python_image(
-                "buildkite-build-test-project-image:py{python_version}-{image_version}".format(
-                    python_version=AvailablePythonVersion.V3_8,  # py version can be bumped when rebuilt
-                    image_version=BUILDKITE_BUILD_TEST_PROJECT_IMAGE_IMAGE_VERSION,
-                ),
+                # py version can be bumped when rebuilt
+                f"buildkite-build-test-project-image:py{AvailablePythonVersion.V3_8}-{BUILDKITE_BUILD_TEST_PROJECT_IMAGE_IMAGE_VERSION}",
                 [
                     "AIRFLOW_HOME",
                     "AWS_ACCOUNT_ID",

.pre-commit-config.yaml

@@ -1,6 +1,6 @@
 repos:
 - repo: https://github.com/charliermarsh/ruff-pre-commit
-  rev: v0.3.0
+  rev: v0.3.4
   hooks:
     - id: ruff
       args: [--fix, --exit-non-zero-on-fix]

examples/deploy_docker/tests/test_deploy_docker.py

@@ -169,11 +169,7 @@ def test_deploy_docker():
         }
 
         launch_res = requests.post(
-            "http://{webserver_host}:3000/graphql?query={query_string}&variables={variables}".format(
-                webserver_host=webserver_host,
-                query_string=LAUNCH_PIPELINE_MUTATION,
-                variables=json.dumps(variables),
-            )
+            f"http://{webserver_host}:3000/graphql?query={LAUNCH_PIPELINE_MUTATION}&variables={json.dumps(variables)}"
         ).json()
 
         assert launch_res["data"]["launchPipelineExecution"]["__typename"] == "LaunchRunSuccess"
@@ -198,11 +194,7 @@ def test_deploy_docker():
         }
 
         launch_res = requests.post(
-            "http://{webserver_host}:3000/graphql?query={query_string}&variables={variables}".format(
-                webserver_host=webserver_host,
-                query_string=LAUNCH_PIPELINE_MUTATION,
-                variables=json.dumps(variables),
-            )
+            f"http://{webserver_host}:3000/graphql?query={LAUNCH_PIPELINE_MUTATION}&variables={json.dumps(variables)}"
         ).json()
 
         assert launch_res["data"]["launchPipelineExecution"]["__typename"] == "LaunchRunSuccess"
@@ -226,11 +218,7 @@ def test_deploy_docker():
         }
 
         launch_res = requests.post(
-            "http://{webserver_host}:3000/graphql?query={query_string}&variables={variables}".format(
-                webserver_host=webserver_host,
-                query_string=LAUNCH_PIPELINE_MUTATION,
-                variables=json.dumps(variables),
-            )
+            f"http://{webserver_host}:3000/graphql?query={LAUNCH_PIPELINE_MUTATION}&variables={json.dumps(variables)}"
         ).json()
 
         assert launch_res["data"]["launchPipelineExecution"]["__typename"] == "LaunchRunSuccess"

examples/docs_snippets/docs_snippets/intro_tutorial/basics/testing/custom_types_test.py

@@ -27,8 +27,8 @@ def less_simple_data_frame_type_check(_, value):
         row = value[i]
         if not isinstance(row, dict):
             raise Failure(
-                "LessSimpleDataFrame should be a list of dicts, got {type_} for row"
-                " {idx}".format(type_=type(row), idx=(i + 1))
+                f"LessSimpleDataFrame should be a list of dicts, got {type(row)} for row"
+                f" {i + 1}"
             )
         row_fields = [field for field in row.keys()]
         if fields != row_fields:

integration_tests/python_modules/dagster-k8s-test-infra/dagster_k8s_test_infra/cluster.py

@@ -68,8 +68,8 @@ def _cluster_provider(request):
                         client = docker.from_env()
                         client.images.get(docker_image)
                         print(
-                            "Found existing image tagged {image}, skipping image build. To rebuild,"
-                            " first run: docker rmi {image}".format(image=docker_image)
+                            f"Found existing image tagged {docker_image}, skipping image build. To rebuild,"
+                            f" first run: docker rmi {docker_image}"
                         )
                     except docker.errors.ImageNotFound:
                         build_and_tag_test_image(docker_image)

integration_tests/test_suites/celery-k8s-test-suite/conftest.py

@@ -27,8 +27,8 @@ def dagster_docker_image():
             client = docker.from_env()
             client.images.get(docker_image)
             print(  # noqa: T201
-                "Found existing image tagged {image}, skipping image build. To rebuild, first run: "
-                "docker rmi {image}".format(image=docker_image)
+                f"Found existing image tagged {docker_image}, skipping image build. To rebuild, first run: "
+                f"docker rmi {docker_image}"
             )
         except docker.errors.ImageNotFound:
             build_and_tag_test_image(docker_image)

integration_tests/test_suites/k8s-test-suite/conftest.py

@@ -51,8 +51,8 @@ def dagster_docker_image() -> str:
             client = docker.from_env()
             client.images.get(docker_image)
             print(  # noqa: T201
-                "Found existing image tagged {image}, skipping image build. To rebuild, first run: "
-                "docker rmi {image}".format(image=docker_image)
+                f"Found existing image tagged {docker_image}, skipping image build. To rebuild, first run: "
+                f"docker rmi {docker_image}"
             )
         except docker.errors.ImageNotFound:
             build_and_tag_test_image(docker_image)

pyproject.toml

@@ -110,7 +110,7 @@ extend-exclude = [
 line-length = 100
 
 # Fail if Ruff is not running this version.
-required-version = "0.3.0"
+required-version = "0.3.4"
 
 [tool.ruff.lint]
 

python_modules/dagster-graphql/dagster_graphql/implementation/execution/__init__.py

@@ -132,9 +132,7 @@ def terminate_pipeline_execution(
     if not valid_status:
         return GrapheneTerminateRunFailure(
             run=graphene_run,
-            message="Run {run_id} could not be terminated due to having status {status}.".format(
-                run_id=run.run_id, status=run.status.value
-            ),
+            message=f"Run {run.run_id} could not be terminated due to having status {run.status.value}.",
         )
 
     if force_mark_as_canceled:

python_modules/dagster-graphql/dagster_graphql/implementation/execution/backfill.py

@@ -134,9 +134,7 @@ def create_and_launch_partition_backfill(
 
         if len(matches) != 1:
             raise DagsterInvariantViolationError(
-                "Partition set names must be unique: found {num} matches for {partition_set_name}".format(
-                    num=len(matches), partition_set_name=partition_set_name
-                )
+                f"Partition set names must be unique: found {len(matches)} matches for {partition_set_name}"
             )
         external_partition_set = next(iter(matches))