Merge pull request #26 from dabapps/React-Native-GET-request-fix

fix for React Native GET requests
dabapps · Mar 7, 2019 · 71250d1 · 71250d1
2 parents b55ef48 + 7a56486
commit 71250d1
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@dabapps/redux-requests",
-  "version": "0.5.1",
+  "version": "0.5.2",
   "description": "Library for simple redux requests",
   "main": "dist/js/index.js",
   "directories": {},

diff --git a/src/ts/utils.ts b/src/ts/utils.ts
@@ -73,9 +73,10 @@ export function apiRequest(options: AxiosRequestConfig): AxiosPromise {
 
   // Axios uses a different key for sending data on a GET request
   if (options.method === 'GET') {
+    const { data, ...getConfig } = config;
     return axios({
-      ...config,
-      params: config.data,
+      ...getConfig,
+      params: data,
     });
   }
   return axios(config);

diff --git a/tests/index.ts b/tests/index.ts
@@ -623,6 +623,7 @@ describe('Requests', () => {
       const params = (myRequest as any).params;
       expect(params.params).toEqual({});
       expect(params.headers).not.toBeUndefined();
+      expect(params).not.toHaveProperty('data');
     });
 
     it('should not modify url if not provided', () => {
@@ -653,6 +654,7 @@ describe('Requests', () => {
       const params = (myRequest as any).params;
       expect(params.params).toEqual({ a: 1 });
       expect(params.headers.b).toBe(2);
+      expect(params).not.toHaveProperty('data');
     });
 
     it('should carry forward our provided data - POST', () => {