API: /namespace set-label on a directory works, but rm-label doesn't

[onnozweers]

Dear dCache devs,

I'm testing with labels in the API. For files, it seems to work as expected. But for directories there is something strange: I can set a label on a directory, but I can't remove it.

[onno@hedgehog14 SpiderScripts]$ curl --config /home/onno/.ada/headers/authorization_header_EAfsrGnaEBc7 --fail --show-error -H 'content-type: application/json' -X POST https://dcachetest.grid.surfsara.nl:20443/api/v1/namespace/%2Fgroups%2Fdteam%2Fonno-tests -d '{"action":"set-label","label":"mylabel"}'
{"status":"success"}

[onno@hedgehog14 SpiderScripts]$ curl --config /home/onno/.ada/headers/authorization_header_EAfsrGnaEBc7 --fail --show-error -H 'content-type: application/json' -X POST https://dcachetest.grid.surfsara.nl:20443/api/v1/namespace/%2Fgroups%2Fdteam%2Fonno-tests -d '{"action":"rm-label","label":"mylabel"}'
curl: (22) The requested URL returned error: 400 Bad Request

In the frontend log:

level=WARN ts=2024-12-31T10:52:25.181+0100 event=org.dcache.frontend.request request.method=POST request.url=https://dcachetest.grid.surfsara.nl:20443/api/v1/namespace//groups/dteam/onno-tests response.code=400 response.reason="Bad Request" socket.remote=[2001:610:108:203a::2:28]:41748 user-agent=curl/7.61.1 user.sub=8571849c-1044-416f-9702-5acb60257479@DTEAM user.jti=dde2813d-29b1-4045-96e7-44743433e9ee@DTEAM user.mapped=36490:31631 request.entity="{"action":"rm-lab[...]l":"mytestlabel"}" response.entity="{"detail":"Directory object cannot [...]" duration=12

So, my guess is that labels are not implemented for directories. This is perfectly fine, I can't think of any use case for that. But wouldn't it be nice if a set-label on a dir also failed?

Please give this a low priority, it's not urgent, once you know how it works you can live with it.

Thanks, and happy new year!

[mksahakyan]

Onno , Happy 2025! Yes you are right we cannot set label on a directory, this should be fixed. Thank you Marina From: "Onno Zweers" ***@***.***> To: "dCache" ***@***.***> Cc: "Subscribed" ***@***.***> Sent: Tuesday, 31 December, 2024 11:12:33 Subject: [dCache/dcache] API: /namespace `set-label` on a directory works, but `rm-label` doesn't (Issue #7726) Dear dCache devs, I'm testing with labels in the API. For files, it seems to work as expected. But for directories there is something strange: I can set a label on a directory, but I can't remove it. ***@***.*** SpiderScripts]$ curl --config /home/onno/.ada/headers/authorization_header_EAfsrGnaEBc7 --fail --show-error -H 'content-type: application/json' -X POST https://dcachetest.grid.surfsara.nl:20443/api/v1/namespace/%2Fgroups%2Fdteam%2Fonno-tests -d '{"action":"set-label","label":"mylabel"}' {"status":"success"} ***@***.*** SpiderScripts]$ curl --config /home/onno/.ada/headers/authorization_header_EAfsrGnaEBc7 --fail --show-error -H 'content-type: application/json' -X POST https://dcachetest.grid.surfsara.nl:20443/api/v1/namespace/%2Fgroups%2Fdteam%2Fonno-tests -d '{"action":"rm-label","label":"mylabel"}' curl: (22) The requested URL returned error: 400 Bad Request In the frontend log: level=WARN ts=2024-12-31T10:52:25.181+0100 event=org.dcache.frontend.request request.method=POST request.url= [ https://dcachetest.grid.surfsara.nl:20443/api/v1/namespace//groups/dteam/onno-tests | https://dcachetest.grid.surfsara.nl:20443/api/v1/namespace//groups/dteam/onno-tests ] response.code=400 response.reason="Bad Request" socket.remote=[2001:610:108:203a::2:28]:41748 user-agent=curl/7.61.1 ***@***.*** ***@***.*** user.mapped=36490:31631 request.entity="{"action":"rm-lab[...]l":"mytestlabel"}" response.entity="{"detail":"Directory object cannot [...]" duration=12 So, my guess is that labels are not implemented for directories. This is perfectly fine, I can't think of any use case for that. But wouldn't it be nice if a set-label on a dir also failed? Please give this a low priority, it's not urgent, once you know how it works you can live with it. Thanks, and happy new year! — Reply to this email directly, [ #7726 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/ADR34RARA5GTMOXJT3EL2LT2IJUZDAVCNFSM6AAAAABUNI5JTSVHI2DSMVQWIX3LMV43ASLTON2WKOZSG43DIMRQGIZTCMQ | unsubscribe ] . You are receiving this because you are subscribed to this thread. Message ID: ***@***.***>