Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full audit #46

Open
nerdstein opened this issue Aug 19, 2015 · 5 comments
Open

Full audit #46

nerdstein opened this issue Aug 19, 2015 · 5 comments

Comments

@nerdstein
Copy link
Contributor

  1. identify anything that is broken
  2. identify any gaps in automated tests
  3. make general observations for improving UX
@nerdstein
Copy link
Contributor Author

Prepping for next d.o release

@nerdstein
Copy link
Contributor Author

please note prafful is working to resolve remaining automated test issues

@pbull
Copy link

pbull commented Aug 21, 2015

Documenting my findings from the past couple days. I should be able to do some additional review/writing tests over the weekend and early next week:

Config files should not define UUID values

Second-level config (/admin/config/security) page returns a 404

ConstraintDelete form throws PHP warnings; Form title is missing tokenized constrain name

Fixes bugs in PasswordReset behavior: #51
When resetting passwords by role, the following bugs were encountered:

  • Users assigned to mutiple roles were being saved more than once (when selecting multiple roles that were assigned to those users)
  • Password reset fails when selecting the "Authenticated users" role
  • Confirmation message prints the array keys (including unselected values) instead of the role names.
  • PasswordReset needs tests.

@nerdstein
Copy link
Contributor Author

@pbull let me know if you are continuing to work on this

@pbull
Copy link

pbull commented Aug 26, 2015

@nerdstein unassigning myself for now, I'll pick this back up if I have more time.

@pbull pbull removed their assignment Aug 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants